fix: resolve failing tests by improving JSDOM mock and mocking DOMPurify#12
Conversation
Summary of ChangesHello @allenhutchison, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on resolving failing tests within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses failing tests by introducing a mock for jsdom and dompurify. The changes are well-targeted to solve the testing issues. The new jsdom mock is a good start, but I've identified a few areas where its robustness could be improved to make it more maintainable and less prone to breaking with future test changes. Specifically, I've commented on improving the implementation of textContent and querySelector, and fixing a potential bug in the HTML parsing regex to handle self-closing tags.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2 participants
This PR fixes the failing tests in
workspace-mcp-server.\n\nChanges:\n- ImprovedJSDOMmock insrc/__tests__/mocks/jsdom.tsto supportquerySelector,attributes, and recursive parsing.\n- Mockeddompurifyinsrc/__tests__/services/DocsService.test.tsto avoid dependency on full DOM implementation.\n- Preserved whitespace inMockDOMParserto fix markdown parsing tests.